Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit # of replay breadcrumbs captured per timeframe #8072

Closed
mydea opened this issue May 8, 2023 · 0 comments · Fixed by #8086
Closed

Limit # of replay breadcrumbs captured per timeframe #8072

mydea opened this issue May 8, 2023 · 0 comments · Fixed by #8086
Assignees
@billyvg
Labels
Package: replay

Comments

@mydea
Copy link
Member

mydea commented May 8, 2023 •
edited

It is possible that a lot of replay breadcrumbs are captured in a short amount of time. E.g. if a page makes continuously hundreds of API requests, we will always capture them all.

We should limit this to a certain upper limit, throttling this for a given time frame.

Proposal

We allow up to 500 breadcrumbs per minute. Anything over this will be discarded. This is a moving window, meaning that a breadcrumb will stop counting towards the limit after 60s.
@mydea mydea mentioned this issue May 9, 2023
Merged
@billyvg billyvg self-assigned this May 15, 2023
billyvg added a commit that referenced this issue May 26, 2023
@mydea @billyvg
feat(replay): Throttle breadcrumbs to max 300/5s (#8086)
f359ef3 
This updates custom breadcrumb handling to be throttled to max. 300
breadcrumbs/5s.

If we exceed this amount of breadcrumbs, we drop any further breadcrumbs
and instead add a single breadcrumb with `category: 'replay.throttled'`,
which the UI can use to indicate that _something_ was dropped.

Closes #8072

---------

Co-authored-by: Billy Vong <billyvg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billyvg billyvg

Labels
Package: replay
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(replay): Throttle breadcrumbs to max 300/5s getsentry/sentry-javascript
2 participants
@billyvg @mydea