ref(browser): Refactor browser integrations to use processEvent
#9022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
force-pushed
the
fn/integration-processEvent
branch
from
c2d603d
to
c354494
Compare
mydea
force-pushed
the
fn/integrations-browser
branch
2 times, most recently
from
16a892a
to
0b42518
Compare
mydea
commented
Sep 15, 2023
| } | ||
|
|
||
| /** @inheritDoc */ | ||
| public preprocessEvent(event: Event): void { |
There was a problem hiding this comment.
I actually figured this prob. makes sense as preprocess, as we may want to generally run this before all other processing, as the other processings may want to access the request?
Lms24
approved these changes
Sep 15, 2023
Yeah so some tests failed during implementing this (which i fixed by now), so I'd say this should be OK covered! |
|
Tests currently fail because of #9034, fix WIP. |
billyvg
approved these changes
Sep 15, 2023
| }; | ||
| return event; | ||
| }, | ||
| { id: 'Replay' }, |
There was a problem hiding this comment.
this is used to identify which event processor dropped an event (possibly). It's optional, but figured it's good form to add this for all our own event processors!
mydea
force-pushed
the
fn/integrations-browser
branch
from
0ebcde1
to
1a24b5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors browser integrations to use the new
processEventhook on the Integrations interface.It also updates Replay to register it's event processor on the client, not globally. This is also needed to ensure the order is somewhat stable, as global processors are run separately from the client ones.