-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta(changelog): Update changelog for 7.71.0 #9103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Gitflow] Merge master into develop
…#9064) Even if no scope is passed. I guess this is kind of behavior changing, but I'd argue it is just fixing an unexpected behaviour that's not actually intuitive/logical - that global event processors are only applied if a scope is provided.
I noticed that while from an API POV the current behavior makes kind-of sense IMHO: 1. Run global event processors 2. Run scope event processors 3. Run client event processors It is potentially breaking, as if we rewrite integrations to use the new client processors, their processing will run after any user global event processors, leading to potentially unexpected outcomes. So this PR changes this to instead run them in this order: 1. Run client event processors 2. Run global event processors 3. Run scope event processors Which should be more stable for now. In v8, we should update this to run a more sensible order: 1. Global 2. Client 3. Scope
…9070) Also update all OTEL dependencies to latest to align these properly. The sdk-trace-node package actually just wraps sdk-trace-base, adds some default exports (that we do not need) + sets the async local storage context manager by default (which we overwrite anyhow). So we can cut down on one dependency there and make this a tiny bit easier. I also made a central `OtelSpan` type in node-experimental to avoid using this everywhere throughout the codebase.
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
) This refactors browser integrations to use the new `processEvent` hook on the Integrations interface. It also updates Replay to register it's event processor on the client, not globally. This is also needed to ensure the order is somewhat stable, as global processors are run separately from the client ones.
Previously, the error name would always be `React ErrorBoundary Error`, because `errorBoundaryError.name` refers to the name of the Error object that was just created.
Bumps [graphql](https://github.com/graphql/graphql-js) from 16.3.0 to 16.8.1. - [Release notes](https://github.com/graphql/graphql-js/releases) - [Commits](graphql/graphql-js@v16.3.0...v16.8.1) --- updated-dependencies: - dependency-name: graphql dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…#9099) Also add tests for this. This can then be reused e.g. by node-experimental in a later step.
…request async storage module (#9100)
mydea
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor bc of #9022