Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta(changelog): Update changelog for 7.71.0 #9103

Merged
merged 16 commits into from
Sep 25, 2023
Merged

Conversation

lforst
Copy link
Member

@lforst lforst commented Sep 25, 2023

Minor bc of #9022

github-actions bot and others added 16 commits September 20, 2023 11:14
[Gitflow] Merge master into develop
…#9064)

Even if no scope is passed.

I guess this is kind of behavior changing, but I'd argue it is just
fixing an unexpected behaviour that's not actually intuitive/logical -
that global event processors are only applied if a scope is provided.
I noticed that while from an API POV the current behavior makes kind-of
sense IMHO:

1. Run global event processors
2. Run scope event processors
3. Run client event processors

It is potentially breaking, as if we rewrite integrations to use the new
client processors, their processing will run after any user global event
processors, leading to potentially unexpected outcomes.

So this PR changes this to instead run them in this order:

1. Run client event processors
2. Run global event processors
3. Run scope event processors

Which should be more stable for now. 

In v8, we should update this to run a more sensible order:

1. Global
2. Client
3. Scope
…9070)

Also update all OTEL dependencies to latest to align these properly.

The sdk-trace-node package actually just wraps sdk-trace-base, adds some
default exports (that we do not need) + sets the async local storage
context manager by default (which we overwrite anyhow).

So we can cut down on one dependency there and make this a tiny bit
easier.

I also made a central `OtelSpan` type in node-experimental to avoid
using this everywhere throughout the codebase.
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
)

This refactors browser integrations to use the new `processEvent` hook
on the Integrations interface.

It also updates Replay to register it's event processor on the client,
not globally. This is also needed to ensure the order is somewhat
stable, as global processors are run separately from the client ones.
Previously, the error name would always be `React ErrorBoundary Error`,
because `errorBoundaryError.name` refers to the name of the Error object
that was just created.
Bumps [graphql](https://github.com/graphql/graphql-js) from 16.3.0 to 16.8.1.
- [Release notes](https://github.com/graphql/graphql-js/releases)
- [Commits](graphql/graphql-js@v16.3.0...v16.8.1)

---
updated-dependencies:
- dependency-name: graphql
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
)

To keep things better together, and in preparation for follow up PRs
with more OTEL-specific stuff.

Nothing functionally changes here, this is just to keep follow up PRs
more readable as there is a lot going on...
…#9099)

Also add tests for this. This can then be reused e.g. by
node-experimental in a later step.
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lforst lforst merged commit 3ee7e00 into master Sep 25, 2023
80 checks passed
@lforst lforst deleted the prepare-release/7.71.0 branch September 25, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants