-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta(changelog): Update changelog for 7.96.0 #10330
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Gitflow] Merge master into develop
…0267) Also deprecate the `Integrations` hash in browser SDKs. I also forgot to add the integrations from `@sentry/integrations` to the migration.md doc, so adding those as well!
…ing` (#10303) These are mostly naming changes to use `span` instead of `transaction` for options. Missing is a new handling for `routingInstrumentation`, which I will tackle in a separate PR.
…Integration` (#10304) Step by step...
Closes #10278 This integration incorrectly used `setup` which then caused issues when the core code was changed. It should have been using `setupOnce`. Unfortunately, `setupOnce` causes issues with the unit tests since it then relies on `getClient` to get the client instance for the client options. I've tried using jest to mock `getClient` but this doesn't work which is likely due to `installedIntegrations`. Because we already have [extensive integration tests for LocalVariables](https://github.com/getsentry/sentry-javascript/tree/develop/dev-packages/node-integration-tests/suites/public-api/LocalVariables) I have removed the unit tests because they are becoming a maintenance burden and actually test less than the integration tests. After v8, I plan to move Local variables lookup to the worker thread at which point we can revisit how these might be better tested in unit tests.
Just noticed that this entry point was broken. `build/npm` doesn't exist because the node package is not a package with CDN bundles. Hence all NPM tarball contents are directly in `build`.
This PR adds a new option for React Router 6 integration, `stripBasename` for leaving out the `basename` from transaction names.
…e-experimental` (#10322) This tests v5.13.22 of mongoose because it's the most commonly use version currently supported by the OpenTelemetry plugin: https://github.com/open-telemetry/opentelemetry-js-contrib/blob/fce7d3b5e478ff7525c9ffe99e59bf35f8c06207/plugins/node/instrumentation-mongoose/src/mongoose.ts#L80 https://www.npmjs.com/package/mongoose?activeTab=versions It's worth noting that at least versions 5 and 7 of `mongoose` also generate `mongodb` spans because they use the library internally and we auto instrument everything. For some unknown reason, `mongoose@v8` does not appear to generate `mongodb` spans and I haven't tested v6 because very few people are using it.
Before submitting a pull request, please take a look at our [Contributing](https://github.com/getsentry/sentry-javascript/blob/master/CONTRIBUTING.md) guidelines and verify: - [ ] If you've added code that should be tested, please add tests. - [ ] Ensure your code lints and the test suite passes (`yarn lint`) & (`yarn test`). fixes: #10305
Due to #10327, this reverts changes to the browser tracing integration as we're actually going to replace this differently.
This was identified as a problem by @edwardgou-sentry , and was incorrectly changed in 7.75.0. I think this should work now as expected 🤔 I added some tests for LCP to hopefully very this works kind of as expected (=even after stopping it you can still get a LCP value).
mydea
approved these changes
Jan 24, 2024
size-limit report 📦
|
mydea
force-pushed
the
prepare-release/7.96.0
branch
from
January 24, 2024 22:25
428d7df
to
bf84267
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.