Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta(changelog): Update changelog for 7.96.0 #10330

Merged
merged 16 commits into from
Jan 24, 2024
Merged

Conversation

AbhiPrasad
Copy link
Member

No description provided.

github-actions bot and others added 15 commits January 23, 2024 19:19
[Gitflow] Merge master into develop
…0267)

Also deprecate the `Integrations` hash in browser SDKs.

I also forgot to add the integrations from `@sentry/integrations` to the
migration.md doc, so adding those as well!
…ing` (#10303)

These are mostly naming changes to use `span` instead of `transaction`
for options.

Missing is a new handling for `routingInstrumentation`, which I will
tackle in a separate PR.
Closes #10278

This integration incorrectly used `setup` which then caused issues when
the core code was changed. It should have been using `setupOnce`.

Unfortunately, `setupOnce` causes issues with the unit tests since it
then relies on `getClient` to get the client instance for the client
options. I've tried using jest to mock `getClient` but this doesn't work
which is likely due to `installedIntegrations`.

Because we already have [extensive integration tests for
LocalVariables](https://github.com/getsentry/sentry-javascript/tree/develop/dev-packages/node-integration-tests/suites/public-api/LocalVariables)
I have removed the unit tests because they are becoming a maintenance
burden and actually test less than the integration tests.

After v8, I plan to move Local variables lookup to the worker thread at
which point we can revisit how these might be better tested in unit
tests.
Just noticed that this entry point was broken. `build/npm` doesn't exist
because the node package is not a package with CDN bundles. Hence all
NPM tarball contents are directly in `build`.
This PR adds a new option for React Router 6 integration,
`stripBasename` for leaving out the `basename` from transaction names.
…e-experimental` (#10322)

This tests v5.13.22 of mongoose because it's the most commonly use
version currently supported by the OpenTelemetry plugin:

https://github.com/open-telemetry/opentelemetry-js-contrib/blob/fce7d3b5e478ff7525c9ffe99e59bf35f8c06207/plugins/node/instrumentation-mongoose/src/mongoose.ts#L80

https://www.npmjs.com/package/mongoose?activeTab=versions

It's worth noting that at least versions 5 and 7 of `mongoose` also
generate `mongodb` spans because they use the library internally and we
auto instrument everything. For some unknown reason, `mongoose@v8` does
not appear to generate `mongodb` spans and I haven't tested v6 because
very few people are using it.
Before submitting a pull request, please take a look at our

[Contributing](https://github.com/getsentry/sentry-javascript/blob/master/CONTRIBUTING.md)
guidelines and verify:

- [ ] If you've added code that should be tested, please add tests.
- [ ] Ensure your code lints and the test suite passes (`yarn lint`) &
(`yarn test`).
fixes: #10305
Due to #10327, this
reverts changes to the browser tracing integration as we're actually
going to replace this differently.
This was identified as a problem by @edwardgou-sentry , and was
incorrectly changed in 7.75.0.

I think this should work now as expected 🤔 I added some tests for LCP to
hopefully very this works kind of as expected (=even after stopping it
you can still get a LCP value).
@AbhiPrasad AbhiPrasad requested a review from mydea January 24, 2024 21:52
Copy link
Contributor

github-actions bot commented Jan 24, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.84 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.04 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.93 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.68 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.06 KB (+0.08% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.25 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.26 KB (0%)
@sentry/browser - Webpack (gzipped) 22.5 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.57 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.13 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.97 KB (-0.08% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.43 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 211.42 KB (-0.1% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.44 KB (-0.17% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.08 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.07 KB (-0.09% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.45 KB (-0.01% 🔽)
@sentry/react - Webpack (gzipped) 22.55 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.11 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.4 KB (+0.03% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (0%)

@AbhiPrasad AbhiPrasad merged commit 29f6031 into master Jan 24, 2024
90 checks passed
@AbhiPrasad AbhiPrasad deleted the prepare-release/7.96.0 branch January 24, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants