Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Deprecate spanStatusfromHttpCode in favour of getSpanStatusFromHttpCode #10361

Merged
merged 2 commits into from
Jan 29, 2024
Merged

feat(core): Deprecate spanStatusfromHttpCode in favour of getSpanStatusFromHttpCode #10361

merged 2 commits into from
Jan 29, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 26, 2024 •
edited

The old export contained a typo/camel-case inconsistency which I fixed in the new export and I opted to prepend the get verb. Came across this while working on #10268 and thought since we can, we should fix it in v8.

Also, this finally:

closes #10184

@Lms24 Lms24 changed the base branch from develop to lms/feat-core-deprecate-span-setHttpStatus January 26, 2024 09:26
@Lms24 Lms24 requested review from lforst, mydea and AbhiPrasad and removed request for lforst January 26, 2024 09:28
@Lms24 Lms24 marked this pull request as ready for review January 26, 2024 09:29
@Lms24 Lms24 mentioned this pull request Jan 26, 2024
Closed
@Lms24 Lms24 self-assigned this Jan 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 26, 2024 •
edited

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.14 KB (+0.34% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.34 KB (+0.4% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.24 KB (+0.39% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.97 KB (+0.42% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.38 KB (+0.83% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.32 KB (+0.13% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.33 KB (+0.13% 🔺)
@sentry/browser - Webpack (gzipped) 22.6 KB (+0.28% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.96 KB (+0.47% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.5 KB (+0.51% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.37 KB (+1.1% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.52 KB (+0.22% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.55 KB (+0.51% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 100.56 KB (+1.09% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.35 KB (+0.25% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.46 KB (+0.99% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.76 KB (+0.41% 🔺)
@sentry/react - Webpack (gzipped) 22.63 KB (+0.24% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.43 KB (+0.33% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.73 KB (+0.56% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.27 KB (added)

mydea
mydea reviewed Jan 26, 2024
View reviewed changes
.vscode/settings.json Outdated
@@ -38,5 +38,6 @@
"editor.codeActionsOnSave": {
"source.organizeImports.biome": "explicit",
},
"editor.defaultFormatter": "biomejs.biome"
"editor.defaultFormatter": "biomejs.biome",
"cSpell.words": ["Statusfrom"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this on purpose here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope definitely not, thanks!

mydea
mydea approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, good catch 🚀

Base automatically changed from lms/feat-core-deprecate-span-setHttpStatus to develop January 29, 2024 09:17
@Lms24 Lms24 force-pushed the lms/feat-core-deprecate-typo-spanStatusfromHttpCode branch from 55c6df2 to d23238b Compare January 29, 2024 09:20
@Lms24 Lms24 enabled auto-merge (squash) January 29, 2024 09:21
@Lms24 Lms24 merged commit 51b0f5d into develop Jan 29, 2024
93 checks passed
@Lms24 Lms24 deleted the lms/feat-core-deprecate-typo-spanStatusfromHttpCode branch January 29, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

@Lms24 Lms24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate Remaining Span class and interface fields
2 participants
@Lms24 @mydea