-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remix): Export missing functions #10385
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to have some tests somewhere (?) and/or some code to make this easier - it's always super brittle to ensure you add a new function to all packages for re-exporting 😬
yeah I also thought about this. We can somewhat assert on these exports in e2e tests (e.g. import them where we call init and throw if they're undefined) but this also doesn't scale well. I have an idea for a script but still need to try it out. |
Looks like we missed re-exporting a couple of recently added functions in the Remix SDK. This PR adds the missing exports:
addIntegration
getClient
getCurrentScope
,getIsolationScope
,getGlobalScope
setMeasurement
getActiveSpan
startSpan
,startSpanManual
,startInactiveSpan
continueTrace
isInitialized
closes #10384