fix(node): Use normal require call to import Undici

[lforst]

Dynamic require will work agains us in bundled server-side situations - e.g. Next.js. We are in Node.js world so require should be available in any case. We also use it in the normal http and https instrumentation.

[AbhiPrasad]

One reason this is there is because diagnostics_channel is only available for Node 16+, won't bundling break when bundling for older versions? (Like Node 14).

[lforst]

I see it as follows: Every bundler has a built-in escape hatch because diagnostics_channel can always be manually externalized. The newer (sane) webpack versions automatically seem to externalize it out of the box, even on older Node.js versions.

Right now dynamicRequire seems to break fetch instrumentation on the Next.js canary: https://github.com/getsentry/sentry-javascript/actions/runs/7713179805/job/21023035517

With this change, it succeeds: https://github.com/getsentry/sentry-javascript/actions/runs/7712921252/job/21022104165

dynamicRequire effectively breaks bundled code. I see this more as a fix I think.

I have the soft opinion that this change is the lesser evil but I am not totally sure tbh. People affected would be people who are on old node versions && on old webpack versions. Wdyt?

[lforst]

I need to dwell on this for a bit. For some reason this doesn't even fix the issue I wanted to fix with this change: https://github.com/getsentry/sentry-javascript/actions/runs/7697605293/job/20975482956 🤔

[github-actions]

size-limit report 📦

Path	Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped)	78.2 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)	69.43 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped)	73.36 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)	63.04 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped)	33.38 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped)	33.25 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped)	31.33 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped)	31.34 KB (0%)
@sentry/browser - Webpack (gzipped)	22.6 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped)	76.17 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)	67.72 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)	33.5 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped)	24.66 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)	213.68 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)	101.49 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)	74.01 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)	36.63 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)	69.8 KB (0%)
@sentry/react - Webpack (gzipped)	22.63 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)	87.42 KB (0%)
@sentry/nextjs Client - Webpack (gzipped)	51.57 KB (0%)
@sentry-internal/feedback - Webpack (gzipped)	17.21 KB (0%)

[AbhiPrasad]

I'm fine with making this change as long as we update troubleshooting docs accordingly.

[lforst]

I will merge this as soon as I have troubleshooting docs merged. Docs code freeze is in place right now tho.