Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(vue): use startInactiveSpan in tracing mixin #10406

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

AbhiPrasad
Copy link
Member

ref #10100

Cannot get rid of transactions completely because we rely on accessing the root span to mutate.

Cannot get rid of transactions completely because we rely on accessing
the root span to mutate
@AbhiPrasad AbhiPrasad requested a review from a team January 29, 2024 22:25
@AbhiPrasad AbhiPrasad self-assigned this Jan 29, 2024
@AbhiPrasad AbhiPrasad requested review from lforst and Lms24 and removed request for a team January 29, 2024 22:25
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.12 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.33 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.22 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.95 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.35 KB (-0.09% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.2 KB (-0.22% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.33 KB (+0.01% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.34 KB (+0.01% 🔺)
@sentry/browser - Webpack (gzipped) 22.6 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.89 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.44 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.32 KB (-0.14% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.51 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.53 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 100.54 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.44 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.4 KB (-0.17% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.73 KB (-0.04% 🔽)
@sentry/react - Webpack (gzipped) 22.63 KB (-0.02% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.4 KB (-0.04% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.7 KB (-0.05% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (-0.04% 🔽)

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just wondering - do we have tests for pageload and navigation transactions? Perhaps we should also add a Vue e2e test 🤔

@AbhiPrasad
Copy link
Member Author

do we have tests for pageload and navigation transactions? Perhaps we should also add a Vue e2e test

We need tests, I can open a PR for that.

@AbhiPrasad AbhiPrasad merged commit 5d10cdb into develop Jan 30, 2024
54 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-vue-tracing-mixin-new-span-api branch January 30, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants