Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): Clean up docker containers with script #10454

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Feb 1, 2024

This PR adds a script to cleanup any docker containers left over from the node integration tests.

  • It uses globby@11 since that is already installed for a couple of our dependencies.
  • It finds all the docker-compose.yml files and runs docker compose down --volumes in those directories.
  • It catches all errors for when docker is not running

@timfish timfish marked this pull request as ready for review February 1, 2024 11:00
@timfish timfish requested a review from mydea February 1, 2024 12:06
@AbhiPrasad AbhiPrasad merged commit afa67bf into getsentry:develop Feb 1, 2024
77 checks passed
@timfish timfish deleted the fix/clean-docker branch February 4, 2024 03:40
onurtemizkan pushed a commit that referenced this pull request Feb 4, 2024
This PR adds a script to cleanup any docker containers left over from
the node integration tests.

- It uses `globby@11` since that is already installed for a couple of
our dependencies.
- It finds all the `docker-compose.yml` files and runs `docker compose
down --volumes` in those directories.
- It catches all errors for when docker is not running
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants