-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): Add Vue 3 E2E tests #10476
Conversation
dev-packages/e2e-tests/test-applications/vue-3/event-proxy-server.ts
Dismissed
Show dismissed
Hide dismissed
@@ -41,7 +41,9 @@ | |||
".next/**", | |||
".svelte-kit/**", | |||
".angular/**", | |||
"angular.json" | |||
"angular.json", | |||
"ember/instance-initializers/**", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had some biome errors for ember files. decided to ignore these for now
transaction_info: { | ||
// So this is weird. The source is set to custom although the route doesn't have a name. | ||
// This also only happens during a navigation. A pageload will set the source as 'route'. | ||
// TODO: Figure out what's going on here. | ||
source: 'custom', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something to maybe tackle in or after #10477: For some reason we set source 'custom'
during a navigation.
Not sure why this is happening but IMO it should be 'route'
, also when navigating. My guess is it's because we set custom
when we take the route name over the actual route "path". Probably this is an edge case, we just didn't test before.
cc @mydea if you find an easy fix for this. Otherwise we follow up on this later.
size-limit report 📦
|
This PR adds e2e tests for a Vue 3 app using `@sentry/vue` Specifically, we test - Catching an error - Pageload transaction - Navigation transaction - Preferring route name over route id
This replaces the `vueRouterInstrumentation` and allows to deprecate browser tracing in the vue package. Waiting for #10476, then we should put these changes on top of the E2E test to verify it still works.
This PR adds e2e tests for a Vue 3 app using
@sentry/vue
Specifically, we test