build(ci): Ensure we run E2E tests when profiling node is skipped #10512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mydea
force-pushed
the
fn/fix-e2e-check
branch
from
9d028b1
to
fecc71e
Compare
lforst
approved these changes
Feb 6, 2024
mydea
force-pushed
the
fn/fix-e2e-check
branch
2 times, most recently
from
7890130
to
5c63f63
Compare
mydea
force-pushed
the
fn/fix-e2e-check
branch
from
5c63f63
to
5c66803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent change to skip the node profiling compile step when it was not changed, we implicitly also skipped the "Prepare E2E tests" job - as that is by default skipped if the dependent job is skipped.
This PR changes this so that we should be running this even if that was skipped. We have to make sure to check that
builditself was not skipped though (as then we want to actually skip this).