Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Allow to pass forceTransaction to startSpan() APIs #10749

Merged
merged 1 commit into from
Feb 26, 2024
Merged

feat(core): Allow to pass forceTransaction to startSpan() APIs #10749

merged 1 commit into from
Feb 26, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 20, 2024 •
edited

This will ensure a span is sent as a transaction to Sentry.

This only implements this option for the core implementation, not yet for OTEL - that is a follow up here: #10807

@mydea mydea self-assigned this Feb 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 20, 2024 •
edited

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.39 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.64 KB (+0.15% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.55 KB (+0.14% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.15 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.82 KB (+0.32% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 32.82 KB (+0.32% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.91 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 30.91 KB (0%)
@sentry/browser - Webpack (gzipped) 22.19 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.79 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.54 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.33 KB (+0.14% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.74 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 211.44 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 100.16 KB (+0.17% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.96 KB (+0.25% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.39 KB (+0.11% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.93 KB (+0.16% 🔺)
@sentry/react - Webpack (gzipped) 22.22 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.35 KB (+0.12% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 49.76 KB (+0.2% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.14 KB (0%)

@mydea
Copy link
Member Author

mydea commented Feb 20, 2024

maybe forceTransaction would be a better option name than isTransaction, because this is rather what it doe?

lforst
lforst approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. I'd love to revisit the name for this if we have a plan what it's gonna look like in the product but that is a future-us issue!

packages/core/test/lib/tracing/trace.test.ts Outdated Show resolved Hide resolved
@mydea mydea changed the title feat(core): Allow to pass isTransaction to startSpan() APIs feat(core): Allow to pass forceTransaction to startSpan() APIs Feb 21, 2024
@mydea mydea marked this pull request as ready for review February 21, 2024 15:44
Lms24
Lms24 approved these changes Feb 21, 2024
View reviewed changes
packages/types/src/startSpanOptions.ts Outdated Show resolved Hide resolved
@mydea mydea force-pushed the fn/startSpan-transaction branch 2 times, most recently from ea23bed to 569def4 Compare February 26, 2024 11:16
@mydea mydea mentioned this pull request Feb 26, 2024
Merged
@mydea mydea merged commit 372e405 into develop Feb 26, 2024
96 checks passed
@mydea mydea deleted the fn/startSpan-transaction branch February 26, 2024 12:13
@mydea mydea mentioned this pull request Feb 27, 2024
Merged
mydea added a commit that referenced this pull request Feb 27, 2024
@mydea
feat(core): Allow to pass forceTransaction to startSpan() APIs (b…
a10187d 
…ackport) (#10819)

This will ensure a span is sent as a transaction to Sentry.

This only implements this option for the core implementation, not yet
for OTEL - that is a follow up here:
#10807

This is a backport to v7 of
#10749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@lforst lforst lforst approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

@s1gr1d s1gr1d Awaiting requested review from s1gr1d

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mydea @lforst @Lms24