Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(remix): Make @remix-run/router a dependency (v7) #10779

Merged
merged 1 commit into from
Feb 21, 2024
Merged

ref(remix): Make @remix-run/router a dependency (v7) #10779

merged 1 commit into from
Feb 21, 2024

Conversation

onurtemizkan
Copy link
Collaborator

Backports #10479 to v7 branch

Original PR Description:

Fixes: #10349
Related: #5860
Related: #10458

Removes dynamic loading of react-router-dom and makes @remix-run/router a peer dependency.

We don't need to dynamically load react-router-dom as our TypeScript version is now up-to-date.

@onurtemizkan
ref(remix): Make @remix-run/router a dependency. (#10479)
670973b 
Fixes: #10349
Related: #5860
Related: #10458

Removes dynamic loading of `react-router-dom` and makes
`@remix-run/router` a peer dependency.

We don't need to dynamically load `react-router-dom` as our TypeScript
version is now up-to-date.
@AbhiPrasad AbhiPrasad merged commit 91c7f07 into v7 Feb 21, 2024
100 checks passed
@AbhiPrasad AbhiPrasad deleted the onur/remix-router-as-dependency-v7-backport branch February 21, 2024 21:11
This was referenced Mar 12, 2024
Merged
Closed
@Lms24 Lms24 mentioned this pull request Mar 20, 2024
Merged
@Lms24 Lms24 mentioned this pull request Apr 10, 2024
Merged
This was referenced May 31, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@onurtemizkan @AbhiPrasad