fix(tracing): Fix TTFB measurement #10970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the navigation entry instead of trying to record ttfb from the transaction start time, which may or may not be adjusted properly when ttfb is called. This closely matches how web-vitals constructs onTTFB, with changes made to match how our existing measurements work.
k-fish
requested review from
a team,
lforst and
Lms24
and removed request for
a team
This was referenced Mar 8, 2024
Closed
Closed
|
Superceded by #11185 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This uses the navigation entry instead of trying to record ttfb from the transaction start time, which may or may not be adjusted properly when ttfb is called. This closely matches how web-vitals constructs onTTFB, with changes made to match how our existing measurements work.
Other