fix incorrect sampled type on Transaction

[quisido]

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@sentry/types does not align with @sentry/core, and it causes build errors when exactOptionalPropertyTypes is true.

Example error below:

.../Yarn/Berry/cache/@sentry-core-npm-7.107.0-d7aa1d2661-10c0.zip/node_modules/@sentry/core/types/tracing/transaction.d.ts:5:22 - error TS2420: Class 'import(".../Yarn/Berry/cache/@sentry-core-npm-7.107.0-d7aa1d2661-10c0.zip/node_modules/@sentry/core/types/tracing/transaction").Transaction' incorrectly implements interface 'import(".../Yarn/Berry/cache/@sentry-types-npm-7.107.0-a994f84978-10c0.zip/node_modules/@sentry/types/types/transaction").Transaction'.
  Types of property 'sampled' are incompatible.
    Type 'boolean | undefined' is not assignable to type 'boolean'.
      Type 'undefined' is not assignable to type 'boolean'.

5 export declare class Transaction extends SpanClass implements TransactionInterface {
                       ~~~~~~~~~~~


Found 1 error in .../Yarn/Berry/cache/@sentry-core-npm-7.107.0-d7aa1d2661-10c0.zip/node_modules/@sentry/core/types/tracing/transaction.d.ts:5

This change fixes this.

[Lms24]

Hey @quisido thanks for opening this PR! Which version are you experiencing this problem on?

Generally, we're going to remove sampled entirely from the SDK so merging the PR into our v8 (develop) branch won't make much sense. We could merge it into v7 though if this is currently causing issues for you on a v7 version of the SDK.

[quisido]

Hey @quisido thanks for opening this PR! Which version are you experiencing this problem on?

Generally, we're going to remove sampled entirely from the SDK so merging the PR into our v8 (develop) branch won't make much sense. We could merge it into v7 though if this is currently causing issues for you on a v7 version of the SDK.

Sorry, yes, v7.

[quisido]

@Lms24 I've opened a PR for v7 at #11146, but fwiw this bug would still need to be fixed on v8 via this PR, as upgrading to v8 would re-introduce the bug otherwise.

[Lms24]

I see, thx for pointing out that this is still a problem in v8 (at least at the moment). I missed that Transaction now inherits ultimately also from SpanContext where we defined the explicit undefined.

As I said, medium-term, we'll remove Transaction so this won't be an issue anymore but for now, let's ensure we fix this. Thanks!