feat(node): Remove deprecated/duplicate/unused definitions #11120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds all good, but let's leave |
This comment was marked as outdated.
This comment was marked as outdated.
AbhiPrasad
approved these changes
Mar 15, 2024
| @@ -36,7 +36,7 @@ const _anrIntegration = ((options: Partial<AnrIntegrationOptions> = {}) => { | |||
| return { | |||
| name: INTEGRATION_NAME, | |||
| setup(client: NodeClient) { | |||
| if (NODE_MAJOR < 16 || (NODE_MAJOR === 16 && (NODE_VERSION.minor || 0) < 17)) { | |||
| if (NODE_VERSION.major < 16 || (NODE_VERSION.major === 16 && NODE_VERSION.minor < 17)) { | |||
There was a problem hiding this comment.
This gives me the reminder we need to clean up GLOBAL_OBJ usage soon.
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…#11120) - Removes `makeMain` impl and exports from node (and downstream SDKs) - Removes custom `getCurrentHub/getClient` impl in favour of core - Removes `callExtensionMethod` as its not called from anywhere - Fixes all the tests that relied on `getClient` never returning undefined - Removes `_callExtensionMethod` from core as it's not used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makeMainimpl and exports from node (and downstream SDKs)getCurrentHub/getClientimpl in favour of corecallExtensionMethodas its not called from anywheregetClientnever returning undefined_callExtensionMethodfrom core as it's not used