Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(node): Remove class based export for local variable integration #11128

Merged
merged 1 commit into from Mar 15, 2024
Merged

ref(node): Remove class based export for local variable integration #11128

merged 1 commit into from Mar 15, 2024

Conversation

AbhiPrasad
Copy link
Member

I think we missed this from removing the other class-based exports.

@AbhiPrasad AbhiPrasad requested review from timfish and a team March 15, 2024 14:09
@AbhiPrasad AbhiPrasad self-assigned this Mar 15, 2024
@AbhiPrasad AbhiPrasad requested review from mydea and lforst and removed request for a team March 15, 2024 14:09
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 82.29 KB (added)
@sentry/browser (incl. Tracing, Replay) 73.62 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 77.43 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.17 KB (added)
@sentry/browser (incl. Tracing) 38.25 KB (added)
@sentry/browser (incl. browserTracingIntegration) 38.25 KB (added)
@sentry/browser (incl. feedbackIntegration) 33.11 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 33.2 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 33.21 KB (added)
@sentry/browser (incl. sendFeedback) 29.17 KB (added)
@sentry/browser 24.35 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 76.62 KB (added)
CDN Bundle (incl. Tracing, Replay) 71.48 KB (added)
CDN Bundle (incl. Tracing) 37.82 KB (added)
CDN Bundle 25.68 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 224.12 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 114.06 KB (added)
CDN Bundle - uncompressed 75.9 KB (added)
@sentry/react (incl. Tracing, Replay) 73.61 KB (added)
@sentry/react 24.37 KB (added)

timfish
timfish approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@timfish timfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AbhiPrasad AbhiPrasad merged commit d26b25d into develop Mar 15, 2024
63 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-node-experimental-LocalVariablesSync branch March 15, 2024 14:56
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@AbhiPrasad @cadesalaberry
ref(node): Remove class based export for local variable integration (g…
ca29bb5 
…etsentry#11128)

I think we missed this from removing the other class-based exports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timfish timfish timfish approved these changes

@mydea mydea Awaiting requested review from mydea mydea was automatically assigned from getsentry/team-web-sdk-frontend

@lforst lforst Awaiting requested review from lforst lforst was automatically assigned from getsentry/team-web-sdk-frontend

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AbhiPrasad @timfish