Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v8/browser): Remove class export for linked errors #11129

Merged
merged 1 commit into from Mar 18, 2024
Merged

feat(v8/browser): Remove class export for linked errors #11129

merged 1 commit into from Mar 18, 2024

Conversation

AbhiPrasad
Copy link
Member

ref #8844

@AbhiPrasad AbhiPrasad requested review from a team, stephanie-anderson and s1gr1d and removed request for a team March 15, 2024 14:11
@AbhiPrasad AbhiPrasad self-assigned this Mar 15, 2024
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 15, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 82.3 KB (added)
@sentry/browser (incl. Tracing, Replay) 73.61 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 77.42 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.17 KB (added)
@sentry/browser (incl. Tracing) 38.23 KB (added)
@sentry/browser (incl. browserTracingIntegration) 38.23 KB (added)
@sentry/browser (incl. feedbackIntegration) 33.1 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 33.19 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 33.19 KB (added)
@sentry/browser (incl. sendFeedback) 29.16 KB (added)
@sentry/browser 24.33 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 76.61 KB (added)
CDN Bundle (incl. Tracing, Replay) 71.47 KB (added)
CDN Bundle (incl. Tracing) 37.8 KB (added)
CDN Bundle 25.67 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 224.11 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 114.05 KB (added)
CDN Bundle - uncompressed 75.89 KB (added)
@sentry/react (incl. Tracing, Replay) 73.59 KB (added)
@sentry/react 24.36 KB (added)

@AbhiPrasad
Copy link
Member Author

Flaked 😠

created issue #11131

s1gr1d
s1gr1d approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

@AbhiPrasad AbhiPrasad merged commit 425b114 into develop Mar 18, 2024
84 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-linkederrors-browser-class branch March 18, 2024 14:24
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@AbhiPrasad @cadesalaberry
feat(v8/browser): Remove class export for linked errors (getsentry#11129
3ffa0dc 
)

ref getsentry#8844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1gr1d s1gr1d s1gr1d approved these changes

@stephanie-anderson stephanie-anderson Awaiting requested review from stephanie-anderson stephanie-anderson was automatically assigned from getsentry/team-web-sdk-frontend

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AbhiPrasad @s1gr1d