New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v8): Remove deprecated integration methods on client #11134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
a team,
stephanie-anderson and
lforst
and removed request for
a team
March 15, 2024 14:48
lforst
approved these changes
Mar 15, 2024
This was referenced Mar 15, 2024
AbhiPrasad
force-pushed
the
abhi-client-deprecated-method
branch
from
March 15, 2024 15:13
0f32589
to
3c5a055
Compare
AbhiPrasad
force-pushed
the
abhi-client-deprecated-method
branch
from
March 15, 2024 15:13
3c5a055
to
bd6817f
Compare
size-limit report 📦
|
flaky replay test :( Going to disable
|
This was referenced Mar 15, 2024
Okay the flaking is unbelievable. I'm going to switch to using |
AbhiPrasad
added a commit
that referenced
this pull request
Mar 15, 2024
closes #11136 closes #11062 closes #11137 closes #11138 closes #11139 In #11134 we changed the playwright tests use a larger GH runner. This should hopefully fix the flaky replay playwright tests. Validating that here. Note that `Detect flaky tests / Check tests for flakiness` runs on the smaller workers, so it'll experience the same issues we had before.
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…11134) Removes `getIntegrationById` and `getIntegration` methods on client. Doesn't touch anything on the hub because we want to shim those methods.
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
closes getsentry#11136 closes getsentry#11062 closes getsentry#11137 closes getsentry#11138 closes getsentry#11139 In getsentry#11134 we changed the playwright tests use a larger GH runner. This should hopefully fix the flaky replay playwright tests. Validating that here. Note that `Detect flaky tests / Check tests for flakiness` runs on the smaller workers, so it'll experience the same issues we had before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
getIntegrationById
andgetIntegration
methods on client. Doesn't touch anything on the hub because we want to shim those methods.