Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v8): Remove deprecated integration methods on client #11134

Merged
merged 8 commits into from Mar 15, 2024

Conversation

AbhiPrasad
Copy link
Member

Removes getIntegrationById and getIntegration methods on client. Doesn't touch anything on the hub because we want to shim those methods.

@AbhiPrasad AbhiPrasad requested review from a team, stephanie-anderson and lforst and removed request for a team March 15, 2024 14:48
@AbhiPrasad AbhiPrasad self-assigned this Mar 15, 2024
@AbhiPrasad AbhiPrasad force-pushed the abhi-client-deprecated-method branch from 0f32589 to 3c5a055 Compare March 15, 2024 15:13
@AbhiPrasad AbhiPrasad force-pushed the abhi-client-deprecated-method branch from 3c5a055 to bd6817f Compare March 15, 2024 15:13
Copy link
Contributor

github-actions bot commented Mar 15, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 82.19 KB (added)
@sentry/browser (incl. Tracing, Replay) 73.52 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 77.33 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.07 KB (added)
@sentry/browser (incl. Tracing) 38.15 KB (added)
@sentry/browser (incl. browserTracingIntegration) 38.15 KB (added)
@sentry/browser (incl. feedbackIntegration) 33.01 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 33.09 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 33.1 KB (added)
@sentry/browser (incl. sendFeedback) 29.08 KB (added)
@sentry/browser 24.25 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 76.57 KB (added)
CDN Bundle (incl. Tracing, Replay) 71.43 KB (added)
CDN Bundle (incl. Tracing) 37.77 KB (added)
CDN Bundle 25.62 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 223.88 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 113.82 KB (added)
CDN Bundle - uncompressed 75.66 KB (added)
@sentry/react (incl. Tracing, Replay) 73.51 KB (added)
@sentry/react 24.27 KB (added)

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) March 15, 2024 16:00
@AbhiPrasad
Copy link
Member Author

flaky replay test :(

Going to disable

  1) [webkit] › replay/extendNetworkBreadcrumbs/fetch/captureResponseBody/test.ts:257:11 › does not capture response body when URL does not match 

    Error: expect(received).toEqual(expected) // deep equality

    - Expected  - 1
    + Received  + 0

    @@ -1,10 +1,9 @@
      Object {
        "category": "fetch",
        "data": Object {
          "method": "POST",
    -     "response_body_size": 13,
          "status_code": 200,
          "url": "http://localhost:7654/bar",
        },
        "timestamp": Any<Number>,
        "type": "http",

      300 |
      301 |   expect(eventData?.breadcrumbs?.length).toBe(1);
    > 302 |   expect(eventData!.breadcrumbs![0]).toEqual({
          |                                      ^
      303 |     timestamp: expect.any(Number),
      304 |     category: 'fetch',
      305 |     type: 'http',

        at /home/runner/work/sentry-javascript/sentry-javascript/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseBody/test.ts:302:38

@AbhiPrasad
Copy link
Member Author

Okay the flaking is unbelievable. I'm going to switch to using ubuntu-20.04-large-js for playwright tests.

@AbhiPrasad AbhiPrasad merged commit 2c09292 into develop Mar 15, 2024
89 of 90 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-client-deprecated-method branch March 15, 2024 17:24
AbhiPrasad added a commit that referenced this pull request Mar 15, 2024
closes #11136
closes #11062
closes #11137
closes #11138
closes #11139

In #11134 we changed
the playwright tests use a larger GH runner. This should hopefully fix
the flaky replay playwright tests. Validating that here.

Note that `Detect flaky tests / Check tests for flakiness` runs on the
smaller workers, so it'll experience the same issues we had before.
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
…11134)

Removes `getIntegrationById` and `getIntegration` methods on client.
Doesn't touch anything on the hub because we want to shim those methods.
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
closes getsentry#11136
closes getsentry#11062
closes getsentry#11137
closes getsentry#11138
closes getsentry#11139

In getsentry#11134 we changed
the playwright tests use a larger GH runner. This should hopefully fix
the flaky replay playwright tests. Validating that here.

Note that `Detect flaky tests / Check tests for flakiness` runs on the
smaller workers, so it'll experience the same issues we had before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants