fix(feedback): Reduce force layout in screenshots #11181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c298lee
commented
Mar 18, 2024
| imageBuffer.width = imageSource.videoWidth; | ||
| imageBuffer.height = imageSource.videoHeight; | ||
| context.drawImage(imageSource, 0, 0, imageSource.videoWidth, imageSource.videoHeight); | ||
| const sourceWidth = imageSource.videoWidth; |
There was a problem hiding this comment.
not mentioned in the doc, but done as a precaution
size-limit report 📦
|
billyvg
approved these changes
Mar 18, 2024
packages/feedback/src/screenshot/components/ScreenshotEditor.tsx
Outdated
Show resolved
Hide resolved
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
Reduce force layout/reflow by reducing calls mentioned [here](https://gist.github.com/paulirish/5d52fb081b3570c81e3a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce force layout/reflow by reducing calls mentioned here