fix(feedback): Only allow screenshots in secure contexts #11188

c298lee · 2024-03-18T22:58:18Z

We use getDisplayMedia to take screenshots, which only works in secure contexts, so disable screenshot when not a secure context.

github-actions · 2024-03-18T23:02:44Z

size-limit report 📦

Path	Size
@sentry/browser (incl. Tracing, Replay, Feedback)	80.75 KB (added)
@sentry/browser (incl. Tracing, Replay)	72.1 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas)	75.9 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	65.66 KB (added)
@sentry/browser (incl. Tracing)	36.7 KB (added)
@sentry/browser (incl. browserTracingIntegration)	36.7 KB (added)
@sentry/browser (incl. feedbackIntegration)	31.38 KB (added)
@sentry/browser (incl. feedbackModalIntegration)	31.49 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration)	31.5 KB (added)
@sentry/browser (incl. sendFeedback)	27.45 KB (added)
@sentry/browser	22.62 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback)	75.09 KB (added)
CDN Bundle (incl. Tracing, Replay)	69.92 KB (added)
CDN Bundle (incl. Tracing)	36.28 KB (added)
CDN Bundle	23.99 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed	219.62 KB (added)
CDN Bundle (incl. Tracing) - uncompressed	109.56 KB (added)
CDN Bundle - uncompressed	71.09 KB (added)
@sentry/react (incl. Tracing, Replay)	72.09 KB (added)
@sentry/react	22.64 KB (added)

…1188) We use [getDisplayMedia](https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getDisplayMedia) to take screenshots, which only works in secure contexts, so disable screenshot when not a secure context.

only enable screenshots in secure contexts

fdf53e3

c298lee requested review from a team and ryan953 March 18, 2024 22:58

ryan953 approved these changes Mar 18, 2024

View reviewed changes

c298lee merged commit b4d7701 into develop Mar 18, 2024
87 checks passed

c298lee deleted the cl/screenshot-secure-contexts-only branch March 18, 2024 23:53