Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Do not include prismaIntegration by default #11265

Merged
merged 3 commits into from Mar 25, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 25, 2024

This seems to have issues in ESM builds (not just in astro, but also saw it in remix), so for now removing this from defaults - users can still add it manually if needed. We may find a better solution for this before v8 is stable.

This seems to have issues in ESM builds (not just in astro, but also saw it in remix), so for now removing this from defaults - users can still add it manually if needed. We may find a better solution for this before v8 is stable.
@mydea mydea self-assigned this Mar 25, 2024
Copy link
Contributor

github-actions bot commented Mar 25, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 80.86 KB (added)
@sentry/browser (incl. Tracing, Replay) 72.21 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 76 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 65.76 KB (added)
@sentry/browser (incl. Tracing) 36.8 KB (added)
@sentry/browser (incl. browserTracingIntegration) 36.8 KB (added)
@sentry/browser (incl. feedbackIntegration) 31.32 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 31.43 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.44 KB (added)
@sentry/browser (incl. sendFeedback) 27.41 KB (added)
@sentry/browser 22.57 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.2 KB (added)
CDN Bundle (incl. Tracing, Replay) 70.04 KB (added)
CDN Bundle (incl. Tracing) 36.4 KB (added)
CDN Bundle 23.96 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 220.02 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 109.97 KB (added)
CDN Bundle - uncompressed 70.99 KB (added)
@sentry/react (incl. Tracing, Replay) 72.19 KB (added)
@sentry/react 22.6 KB (added)

@mydea mydea merged commit 2774d1a into develop Mar 25, 2024
63 checks passed
@mydea mydea deleted the fn/disable-prisma-default branch March 25, 2024 12:21
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
…11265)

This seems to have issues in ESM builds (not just in astro, but also saw
it in remix), so for now removing this from defaults - users can still
add it manually if needed. We may find a better solution for this before
v8 is stable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants