Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nextjs): Show misconfiguration warning (no instrumentation.ts) #11266

Merged
merged 1 commit into from Mar 25, 2024
Merged

fix(nextjs): Show misconfiguration warning (no instrumentation.ts) #11266

merged 1 commit into from Mar 25, 2024

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Mar 25, 2024

The warning existed, but was not called

@s1gr1d s1gr1d requested a review from lforst March 25, 2024 12:12
lforst
lforst approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!

@s1gr1d s1gr1d enabled auto-merge (squash) March 25, 2024 12:15
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 80.86 KB (added)
@sentry/browser (incl. Tracing, Replay) 72.21 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 76 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 65.76 KB (added)
@sentry/browser (incl. Tracing) 36.8 KB (added)
@sentry/browser (incl. browserTracingIntegration) 36.8 KB (added)
@sentry/browser (incl. feedbackIntegration) 31.32 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 31.43 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.44 KB (added)
@sentry/browser (incl. sendFeedback) 27.41 KB (added)
@sentry/browser 22.57 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.2 KB (added)
CDN Bundle (incl. Tracing, Replay) 70.04 KB (added)
CDN Bundle (incl. Tracing) 36.4 KB (added)
CDN Bundle 23.96 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 220.02 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 109.97 KB (added)
CDN Bundle - uncompressed 70.99 KB (added)
@sentry/react (incl. Tracing, Replay) 72.19 KB (added)
@sentry/react 22.6 KB (added)

@s1gr1d s1gr1d merged commit 32b6a99 into develop Mar 25, 2024
62 checks passed
@s1gr1d s1gr1d deleted the sig-nextjs-misconfig-warning branch March 25, 2024 12:23
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@s1gr1d @cadesalaberry
fix(nextjs): Show misconfiguration warning (no instrumentation.ts) (g…
0f662a2 
…etsentry#11266)

The warning existed, but was not called
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@s1gr1d @lforst