Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v8/core): Remove deprecated span.sampled #11274

Merged
merged 2 commits into from Mar 26, 2024
Merged

feat(v8/core): Remove deprecated span.sampled #11274

merged 2 commits into from Mar 26, 2024

Conversation

AbhiPrasad
Copy link
Member

ref #10100

Removes span.sampled, and rewrites transaction sampling to avoid mutating transaction.

@AbhiPrasad AbhiPrasad requested review from mydea, a team and Lms24 and removed request for a team March 25, 2024 16:18
@AbhiPrasad AbhiPrasad self-assigned this Mar 25, 2024
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 25, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 25, 2024 •
edited

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 80.73 KB (added)
@sentry/browser (incl. Tracing, Replay) 72.08 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 75.88 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 65.63 KB (added)
@sentry/browser (incl. Tracing) 36.71 KB (added)
@sentry/browser (incl. browserTracingIntegration) 36.71 KB (added)
@sentry/browser (incl. feedbackIntegration) 31.31 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 31.42 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.43 KB (added)
@sentry/browser (incl. sendFeedback) 27.4 KB (added)
@sentry/browser 22.56 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.1 KB (added)
CDN Bundle (incl. Tracing, Replay) 69.93 KB (added)
CDN Bundle (incl. Tracing) 36.31 KB (added)
CDN Bundle 23.92 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.62 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 109.57 KB (added)
CDN Bundle - uncompressed 70.88 KB (added)
@sentry/react (incl. Tracing, Replay) 72.05 KB (added)
@sentry/react 22.59 KB (added)

@AbhiPrasad AbhiPrasad merged commit 902c93e into develop Mar 26, 2024
93 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-span-sampling branch March 26, 2024 12:33
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@AbhiPrasad @cadesalaberry
feat(v8/core): Remove deprecated span.sampled (getsentry#11274)
4c4a783 
ref getsentry#10100

Removes `span.sampled`, and rewrites transaction sampling to avoid
mutating transaction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24 Lms24 was automatically assigned from getsentry/team-web-sdk-frontend

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AbhiPrasad @mydea