Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v8): Remove makeMain export #11278

Merged
merged 1 commit into from Mar 26, 2024
Merged

feat(v8): Remove makeMain export #11278

merged 1 commit into from Mar 26, 2024

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Mar 25, 2024 •
edited

ref #10100

Goodbye makeMain

@AbhiPrasad AbhiPrasad requested a review from a team March 25, 2024 21:19
@AbhiPrasad AbhiPrasad self-assigned this Mar 25, 2024
@AbhiPrasad AbhiPrasad requested review from mydea and s1gr1d and removed request for a team March 25, 2024 21:19
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 25, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 80.78 KB (added)
@sentry/browser (incl. Tracing, Replay) 72.13 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 75.93 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 65.68 KB (added)
@sentry/browser (incl. Tracing) 36.73 KB (added)
@sentry/browser (incl. browserTracingIntegration) 36.73 KB (added)
@sentry/browser (incl. feedbackIntegration) 31.33 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 31.44 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.45 KB (added)
@sentry/browser (incl. sendFeedback) 27.4 KB (added)
@sentry/browser 22.56 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.11 KB (added)
CDN Bundle (incl. Tracing, Replay) 69.93 KB (added)
CDN Bundle (incl. Tracing) 36.31 KB (added)
CDN Bundle 23.92 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.7 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 109.65 KB (added)
CDN Bundle - uncompressed 70.85 KB (added)
@sentry/react (incl. Tracing, Replay) 72.1 KB (added)
@sentry/react 22.59 KB (added)

@AbhiPrasad AbhiPrasad merged commit d06af96 into develop Mar 26, 2024
93 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-makeMain branch March 26, 2024 12:34
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@AbhiPrasad @cadesalaberry
feat(v8): Remove makeMain export (getsentry#11278)
16bfacf 
ref getsentry#10100

Goodbye `makeMain`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@s1gr1d s1gr1d Awaiting requested review from s1gr1d s1gr1d was automatically assigned from getsentry/team-web-sdk-frontend

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AbhiPrasad @mydea