Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): Use suppressTracing to avoid capturing otel spans #11288

Merged
merged 1 commit into from Mar 26, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 26, 2024

I leave the other checks (e.g. in http integration) in there, for now (where we check if the url is sentry URL), but this should ensure we are also not picked up by any other OTEL instrumentation etc.

@mydea mydea requested review from lforst and AbhiPrasad March 26, 2024 15:32
@mydea mydea self-assigned this Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Bundle Report

Changes will decrease total bundle size by 2.68MB ⬇️

Bundle name Size Change
@sentry/node-cjs 335.85kB 41.21kB ⬆️
@sentry/node-esm 332.49kB 41.2kB ⬆️
@sentry/sveltekit-cjs 69.31kB 0 bytes
@sentry/aws-serverless-cjs 14.62kB 5.63kB ⬇️
@sentry/remix-cjs 53.62kB 0 bytes
@sentry/remix-esm 48.23kB 0 bytes
@sentry-internal/node-integration-tests-cjs 1.04kB 0 bytes
@sentry/sveltekit-esm 61.08kB 0 bytes
@sentry-internal/node-integration-tests-esm 888 bytes 0 bytes
@sentry/astro-cjs 27.13kB 0 bytes
@sentry/astro-esm 23.39kB 0 bytes
@sentry/bun-cjs 13.49kB 0 bytes
@sentry/bun-esm 10.07kB 0 bytes
@sentry/google-cloud-serverless-cjs 22.97kB 0 bytes
@sentry/google-cloud-serverless-esm 19.15kB 0 bytes
@sentry/profiling-node-cjs 25.5kB 0 bytes
@sentry/profiling-node-esm 25.52kB 0 bytes
@sentry/core-esm (removed) 239.08kB ⬇️
@sentry/types-cjs (removed) 35 bytes ⬇️
@sentry-internal/integration-shims-cjs (removed) 3.65kB ⬇️
@sentry/vercel-edge-cjs (removed) 18.23kB ⬇️
@sentry/node-experimental-esm (removed) 149.75kB ⬇️
@sentry/node-experimental-cjs (removed) 156.31kB ⬇️
@sentry/utils-cjs (removed) 179.0kB ⬇️
@sentry-internal/replay-esm (removed) 306.29kB ⬇️
@sentry-internal/integration-shims-esm (removed) 2.99kB ⬇️
@sentry/types-esm (removed) 35 bytes ⬇️
@sentry/utils-esm (removed) 174.41kB ⬇️
@sentry-internal/replay-canvas-cjs (removed) 29.43kB ⬇️
@sentry-internal/replay-cjs (removed) 306.18kB ⬇️
@sentry/wasm-esm (removed) 4.85kB ⬇️
@sentry/browser-cjs (removed) 107.15kB ⬇️
@sentry/react-cjs (removed) 45.04kB ⬇️
@sentry/vue-esm (removed) 18.85kB ⬇️
@sentry/svelte-esm (removed) 12.72kB ⬇️
@sentry/svelte-cjs (removed) 13.84kB ⬇️
@sentry-internal/replay-canvas-esm (removed) 29.34kB ⬇️
@sentry/vue-cjs (removed) 20.19kB ⬇️
@sentry-internal/feedback-cjs (removed) 64.82kB ⬇️
@sentry/wasm-cjs (removed) 5.2kB ⬇️
@sentry/react-esm (removed) 41.18kB ⬇️
@sentry/opentelemetry-cjs (removed) 70.06kB ⬇️
@sentry/core-cjs (removed) 242.64kB ⬇️
@sentry/vercel-edge-esm (removed) 16.13kB ⬇️
@sentry-internal/tracing-cjs (removed) 107.96kB ⬇️
@sentry/gatsby-cjs (removed) 2.88kB ⬇️
@sentry/nextjs-cjs (removed) 20.52kB ⬇️
@sentry-internal/feedback-esm (removed) 64.54kB ⬇️
@sentry/gatsby-esm (removed) 2.27kB ⬇️
@sentry/opentelemetry-esm (removed) 68.97kB ⬇️
@sentry-internal/tracing-esm (removed) 107.22kB ⬇️
@sentry/nextjs-esm (removed) 20.02kB ⬇️
@sentry/browser-esm (removed) 104.35kB ⬇️

Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 80.55 KB (added)
@sentry/browser (incl. Tracing, Replay) 71.89 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 75.7 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 65.44 KB (added)
@sentry/browser (incl. Tracing) 36.71 KB (added)
@sentry/browser (incl. browserTracingIntegration) 36.71 KB (added)
@sentry/browser (incl. feedbackIntegration) 31.35 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 31.46 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.47 KB (added)
@sentry/browser (incl. sendFeedback) 27.42 KB (added)
@sentry/browser 22.58 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.9 KB (added)
CDN Bundle (incl. Tracing, Replay) 69.73 KB (added)
CDN Bundle (incl. Tracing) 36.3 KB (added)
CDN Bundle 23.94 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.01 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 109.57 KB (added)
CDN Bundle - uncompressed 70.92 KB (added)
@sentry/react (incl. Tracing, Replay) 71.87 KB (added)
@sentry/react 22.61 KB (added)

@mydea mydea merged commit 7325abb into develop Mar 26, 2024
64 checks passed
@mydea mydea deleted the fn/ensure-suppress-tracing branch March 26, 2024 15:58
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
…ntry#11288)

I leave the other checks (e.g. in http integration) in there, for now
(where we check if the url is sentry URL), but this should ensure we are
also not picked up by any other OTEL instrumentation etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants