Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: remove node-experimental references #11290

Merged
merged 1 commit into from Mar 27, 2024
Merged

ref: remove node-experimental references #11290

merged 1 commit into from Mar 27, 2024

Conversation

AbhiPrasad
Copy link
Member

With this change, there are two remaining references to node-experimental.

  1. nextjs, which is handled by feat(nextjs): Use OpenTelemetry for performance monitoring and tracing #11016
  2. express integration tests, which I will address after feat(node): Ensure tracePropagationTargets are respected #11285 gets merged

Once those two are done, we can remove the old node packages entirely!

@AbhiPrasad AbhiPrasad requested a review from mydea March 26, 2024 15:56
@codecov Codecov

This comment was marked as resolved.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 80.55 KB (added)
@sentry/browser (incl. Tracing, Replay) 71.89 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 75.7 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 65.44 KB (added)
@sentry/browser (incl. Tracing) 36.71 KB (added)
@sentry/browser (incl. browserTracingIntegration) 36.71 KB (added)
@sentry/browser (incl. feedbackIntegration) 31.35 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 31.46 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.47 KB (added)
@sentry/browser (incl. sendFeedback) 27.42 KB (added)
@sentry/browser 22.58 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.9 KB (added)
CDN Bundle (incl. Tracing, Replay) 69.73 KB (added)
CDN Bundle (incl. Tracing) 36.3 KB (added)
CDN Bundle 23.94 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.01 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 109.57 KB (added)
CDN Bundle - uncompressed 70.92 KB (added)
@sentry/react (incl. Tracing, Replay) 71.87 KB (added)
@sentry/react 22.61 KB (added)

@AbhiPrasad AbhiPrasad requested review from a team and stephanie-anderson and removed request for a team March 26, 2024 16:26
@AbhiPrasad AbhiPrasad merged commit a470a4e into develop Mar 27, 2024
59 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-node-experimental-cleanup branch March 27, 2024 13:11
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@AbhiPrasad @cadesalaberry
ref: remove node-experimental references (getsentry#11290)
9681aaa 
With this change, there are two remaining references to
node-experimental.

1. nextjs, which is handled by
getsentry#11016
2. express integration tests, which I will address after
getsentry#11285 gets merged

Once those two are done, we can remove the old node packages entirely!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@stephanie-anderson stephanie-anderson Awaiting requested review from stephanie-anderson stephanie-anderson was automatically assigned from getsentry/team-web-sdk-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AbhiPrasad @mydea