Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/typescript typings #1183

Merged
merged 3 commits into from Jan 10, 2018
Merged

Feature/typescript typings #1183

merged 3 commits into from Jan 10, 2018

Conversation

dawnmist
Copy link
Contributor

  • Update captureException to match support of ErrorEvent and string as permitted inputs for the exception (fixes issue Incorrect TypeScript typings #1167).
  • Update setExtraContext to allow using setExtraContext() to clear the extra data.
  • Update setTagsContext to allow using setTagsContext() to clear the tags data.
  • Add tests for the above changes.
  • Add additional test calls for the Raven.context and Raven.wrap to take a function that throws an ErrorEvent.
  • Update minimum Typescript version to 2.3.0, as the type definitions for ErrorEvent are incorrect/unusable in versions of Typescript less than 2.3.0.

Before submitting a pull request, please verify the following:

  • If you've added code that should be tested, please add tests.
  • If you've modified the API (e.g. added a new config or public method), update the docs and TypeScript declaration file
  • Ensure your code lints and the test suite passes (npm test) - the changes are solely to the typescript definitions as expansions of the current function definitions. The typescript tests work, but there are a few breadcrumb tests that are failing on Firefox 52.0.0/Linux. I believe those failures are completely unrelated to the typescript function type definitions, and thus not relevant to this pull request.

@dawnmist
Updates to typescript types definitions.
df89ac9 
* Update captureException to match support of ErrorEvent and string as permitted inputs for the exception (fixes issue getsentry#1167).
* Update setExtraContext to allow using setExtraContext() to clear the extra data.
* Update setTagsContext to allow using setTagsContext() to clear the tags data.
* Add tests for the above changes.
* Add additional test calls for the Raven.context and Raven.wrap to take a function that throws an ErrorEvent.
* Update minimum Typescript version to 2.3.0, as the type definitions for ErrorEvent are incorrect/unusable in versions of Typescript less than 2.3.0.
@dawnmist
Update usage documentation.
5be67e9 
Add documentation for how to remove a tag from the tag context data, and how to remove a value from the extra context data, as described in issue getsentry#614.
@dawnmist
Add missing console log levels to LogLevel.
f4e82a4 
Raven's autoBreadcrumbs function for console messages uses the console's log levels. This means that the list of loglevels used for console breadcrumbs is 'debug', 'info', 'warn', 'error', 'log'. The values 'warn' and 'log' were missing in the list of possible LogLevels.
@kamilogorek kamilogorek merged commit 2efb497 into getsentry:master Jan 10, 2018
@kamilogorek
Copy link
Contributor

Thanks @dawnmist! :)

@kamilogorek kamilogorek mentioned this pull request Jan 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dawnmist @kamilogorek