fix: Do not include credentials by default #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts a default
credentials: 'include'for fetch that was set in #1177. This default was primarily added for self-hosted Sentry installations and should therefore require explicit configuration withfetchOptions.Most importantly, this breaks when a user with Sentry account (and therefore an active sentry.io cookie) visits any webpage using the Raven SDK. The cookie will be rejected by CORS protection because Sentry does not send a
Access-Control-Allow-Credentials. This is expected behavior, see getsentry/sentry#6970 for more information.Also, this is not usual browser behavior and should therefore not be default. And, it is inconsistent with the
XMLHttpRequestimplementation which does not include credentials by default.Fixes getsentry/sentry#6970