Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta(changelog): Update changelog for 8.0.0-rc.0 #11916

Merged
merged 13 commits into from
May 6, 2024

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented May 6, 2024

No description provided.

github-actions bot and others added 10 commits May 3, 2024 20:16
[Gitflow] Merge master into develop
This reverts #11888,
and ensures the feedback tests actually work on CDN.

For this, we now ensure to serve this locally, so this will work also on
release branches. It means you have to use `getLocalTestUrl` instead of
`getLocalTestPath` to work. (side note: We can/should probably just
remove `getLocalTestPath` overall 🤔 URL based is much more realistic and
IMHO better. I'll do that in a follow up, maybe.
As some instrumentation may need higher versions, which we don't want to
block there. This shuld be treated more like core etc.

Note that deduping this does not really work nicely, sadly, because this
is still experimental (`0.x`) so `^0.50.0` will not match `0.51.0` 😞
This PR bumps the hapi instrumentation to v0.38.0, which now supports
hapi 21:
https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-hapi-v0.38.0

It also re-adds the hapi E2E test.

Closes #11411
[See CHANGELOG](https://github.com/jsdom/jsdom/blob/main/Changelog.md)

21.1.2 is the latest version that still provides support for node v14
This prints a console.warn out if we detect that we are running in ESM
mode.
@s1gr1d s1gr1d requested review from lforst, HazAT and mydea May 6, 2024 15:17
CHANGELOG.md Outdated
Comment on lines 11 to 12
We also recommend, reading the detailed
[migration guide](https://docs.sentry.io/platforms/javascript/migration/v7-to-v8/) in the docs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We also recommend, reading the detailed
[migration guide](https://docs.sentry.io/platforms/javascript/migration/v7-to-v8/) in the docs.
We recommend to read the detailed
[migration guide](https://docs.sentry.io/platforms/javascript/migration/v7-to-v8/) in the docs.

CHANGELOG.md Outdated
Chrome 63 Edge 79 Safari/iOS Safari 12 Firefox 58 Opera 50 Samsung Internet 8.2

For more details, please see the
[version support section in migration guide](https://github.com/getsentry/sentry-javascript/blob/8.0.0-beta.1/MIGRATION.md#1-version-support-changes).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[version support section in migration guide](https://github.com/getsentry/sentry-javascript/blob/8.0.0-beta.1/MIGRATION.md#1-version-support-changes).
[version support section in migration guide](https://github.com/getsentry/sentry-javascript/blob/develop/MIGRATION.md#1-version-support-changes).

should this be the docs on develop? 🤔

CHANGELOG.md Outdated

We now officially support Node 22.

- **fix(node): Fix nest.js error handler (#11874)**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move all these fixes down to "Other Changes" - important here is really the big, breaking stuff only!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added all important changes from the last beta releases plus Node 22 support and the one with Nest.js as the Nest.js fix is a breaking change, right?

CHANGELOG.md Outdated
This change was made to integrate more nicely with the HTTP instrumentation added in earlier versions to avoid creating
unnecessary transactions.

- **feat(browser): Update `propagationContext` on `spanEnd` to keep trace consistent**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really all of these should probably be under "other changes" I believe, coming here you have no context of all the other hundreds of changes in the rc 😅

@s1gr1d s1gr1d force-pushed the prepare-release/v8.0.0-rc.0 branch from 1a1e94c to fee4af9 Compare May 6, 2024 15:44
@s1gr1d s1gr1d requested a review from mydea May 6, 2024 15:45
CHANGELOG.md Outdated
Comment on lines 35 to 36
When running Sentry in ESM mode, you will get a warning about that. Consider transpiling your application to CJS
(CommonJS) in your production build.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When running Sentry in ESM mode, you will get a warning about that. Consider transpiling your application to CJS
(CommonJS) in your production build.
When running Sentry in ESM mode, we will now warn you that this is not supported as of now. We are working on ensuring support with ESM builds.

maybe something like this? 🤔

CHANGELOG.md Outdated
Comment on lines 40 to 41
- dev: Upgrade to `jsdom@21.1.2` (#11900)
- docs: fix typo in doc for `reactRouterV6BrowserTracingIntegration` (#11896)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- dev: Upgrade to `jsdom@21.1.2` (#11900)
- docs: fix typo in doc for `reactRouterV6BrowserTracingIntegration` (#11896)

no need to highlight docs/dev changes in here :)

CHANGELOG.md Outdated
Comment on lines 15 to 26
### Version Support

The Sentry JavaScript SDK v8 now supports Node.js 14.8.0 or higher. This applies to @sentry/node and all of our
node-based server-side sdks (@sentry/nextjs, @sentry/remix, etc.).

The browser SDKs now require ES2018+ compatible browsers. New minimum browser versions:

Chrome 63 Edge 79 Safari/iOS Safari 12 Firefox 58 Opera 50 Samsung Internet 8.2

For more details, please see the
[version support section in migration guide](https://github.com/getsentry/sentry-javascript/blob/develop/MIGRATION.md#1-version-support-changes).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Version Support
The Sentry JavaScript SDK v8 now supports Node.js 14.8.0 or higher. This applies to @sentry/node and all of our
node-based server-side sdks (@sentry/nextjs, @sentry/remix, etc.).
The browser SDKs now require ES2018+ compatible browsers. New minimum browser versions:
Chrome 63 Edge 79 Safari/iOS Safari 12 Firefox 58 Opera 50 Samsung Internet 8.2
For more details, please see the
[version support section in migration guide](https://github.com/getsentry/sentry-javascript/blob/develop/MIGRATION.md#1-version-support-changes).

I think we can omit this as well here then, keep it a "normal"/"small" changelog!

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Don't forget to change the PR target to master before merging with merge commit 🚀 :shipit:

@s1gr1d s1gr1d changed the base branch from develop to master May 6, 2024 15:52
@s1gr1d s1gr1d requested review from a team as code owners May 6, 2024 15:52
@s1gr1d s1gr1d merged commit 561a7d1 into master May 6, 2024
28 checks passed
@s1gr1d s1gr1d deleted the prepare-release/v8.0.0-rc.0 branch May 6, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants