Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Export Scope interface as Scope #12067

Merged
merged 1 commit into from
May 16, 2024
Merged

fix(core): Export Scope interface as Scope #12067

merged 1 commit into from
May 16, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented May 16, 2024

To make interop with e.g. importing Scope from @sentry/node easier.

Closes #12053

@mydea
fix(core): Export Scope interface as Scope
5e584d4 
To make interop with e.g. importing `Scope` from `@sentry/node` easier.
@mydea mydea self-assigned this May 16, 2024
@mydea mydea mentioned this pull request May 16, 2024
Closed
3 tasks
andreiborza
andreiborza approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

Lms24
Lms24 approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 😅

@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 21.68 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) 32.76 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) 68.1 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.5 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.14 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.14 KB (-0.01% 🔽)
@sentry/browser (incl. Feedback) 37.63 KB (+0.07% 🔺)
@sentry/browser (incl. sendFeedback) 26.25 KB (+0.06% 🔺)
@sentry/browser (incl. FeedbackAsync) 30.62 KB (+0.05% 🔺)
@sentry/react 24.37 KB (+0.04% 🔺)
@sentry/react (incl. Tracing) 35.74 KB (+0.07% 🔺)
@sentry/vue 25.53 KB (+0.09% 🔺)
@sentry/vue (incl. Tracing) 34.55 KB (+0.04% 🔺)
@sentry/svelte 21.81 KB (+0.06% 🔺)
CDN Bundle 24.22 KB (+0.06% 🔺)
CDN Bundle (incl. Tracing) 34.18 KB (+0.01% 🔺)
CDN Bundle (incl. Tracing, Replay) 67.86 KB (+0.01% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 72.85 KB (+0.04% 🔺)
CDN Bundle - uncompressed 71.21 KB (+0.02% 🔺)
CDN Bundle (incl. Tracing) - uncompressed 101.34 KB (+0.02% 🔺)
CDN Bundle (incl. Tracing, Replay) - uncompressed 210.96 KB (+0.01% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 223.27 KB (+0.01% 🔺)
@sentry/nextjs (client) 34.97 KB (+0.03% 🔺)
@sentry/sveltekit (client) 33.33 KB (+0.03% 🔺)
@sentry/node 141.03 KB (+0.01% 🔺)
@sentry/aws-serverless 128.05 KB (+0.01% 🔺)

@mydea mydea merged commit 4a1f2ac into develop May 16, 2024
100 checks passed
@mydea mydea deleted the fn/scope-type branch May 16, 2024 11:52
@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Closed
This was referenced Jun 6, 2024
Open
Open
@naiba4 naiba4 mentioned this pull request Jun 7, 2024
Open
@omznc omznc mentioned this pull request Jun 7, 2024
Open
@coderbyheart coderbyheart mentioned this pull request Jun 7, 2024
Open
@paaschdigital paaschdigital mentioned this pull request Jun 8, 2024
Open
@Cachiman Cachiman mentioned this pull request Jun 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@andreiborza andreiborza andreiborza approved these changes

@s1gr1d s1gr1d Awaiting requested review from s1gr1d

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple incompatible Scope types in v8.x
3 participants
@mydea @Lms24 @andreiborza