Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): Change import of @prisma/instrumentation to use default import #12185

Merged
merged 2 commits into from
May 24, 2024
Merged

fix(node): Change import of @prisma/instrumentation to use default import #12185

merged 2 commits into from
May 24, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented May 23, 2024 •
edited

Potentially fixes #11216

In esm due to interop, the PrismaInstrumentation can be found under default.

@lforst lforst marked this pull request as ready for review May 24, 2024 12:44
@lforst lforst requested review from mydea and Lms24 May 24, 2024 12:45
mydea
mydea approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭 well if it works, I guess...!

@lforst lforst merged commit 8fa393c into develop May 24, 2024
87 checks passed
@lforst lforst deleted the lforst-fix-prisma-esm-import branch May 24, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prismaInstrumentation.PrismaInstrumentation is not a constructor
3 participants
@lforst @mydea @Lms24