Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Let Edge to send fetch requests using default config #1236

Merged
merged 1 commit into from
Feb 21, 2018

Conversation

kamilogorek
Copy link
Contributor

Fixes #1233

We add referrer because this comment #1177 (comment)

However, there's no easy way to test this behavior, as:

  • mocking fetch won't call it's native implementation, therefore not throw an error
  • spying on fetch won't modify response object, and without it, we'll always jump into onError handler because we get no ok in resp data

I'm not really convinced if this is a good idea... It just feels odd, but I cannot think of any simple, yet an acceptable solution to this issue.

Thoughts?

@kamilogorek kamilogorek requested a review from a team February 20, 2018 10:40
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is fine and probably the only thing we could do here.
Even though I am not sure if we still require referrer on the server but we can't force people to update their server so we have to live with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants