fix(node): Ensure status is correct for http server span errors #12477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Lms24
approved these changes
Jun 12, 2024
mydea
pushed a commit
that referenced
this pull request
Jun 13, 2024
Updates the expected status message for 404 span reflecting the updates in #12477
mydea
added a commit
that referenced
this pull request
Jun 13, 2024
Ensure we run node-integration, remix, nextjs tests for changes in opentelemetry package. You can see how this PR: #12477 did not trigger node-integration tests 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we were not correctly setting a status message based on http status for errored http.server span.
The problem was in our logic, where we already had the status set to
{ code: 2, message: undefined }, and whenever the code was not 0 (unset), we'd never look at the attributes to infer the proper status message.Now, if we have code: 2 but not message, we try to infer the message from the attributes, if possible.