Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Allow to configure maxSpanWaitDuration #12610

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Jun 24, 2024

Adds back #12492.

We were experimenting with #12510 but found it infeasible to do: #12577 (comment)

Closes #12510

@lforst lforst requested review from mydea and AbhiPrasad June 24, 2024 10:28
Copy link
Contributor

github-actions bot commented Jun 24, 2024

size-limit report 📦

Path Size
@sentry/browser 22.22 KB (0%)
@sentry/browser (incl. Tracing) 33.31 KB (0%)
@sentry/browser (incl. Tracing, Replay) 69.09 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.42 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.15 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.34 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87.21 KB (0%)
@sentry/browser (incl. metrics) 26.5 KB (0%)
@sentry/browser (incl. Feedback) 38.45 KB (0%)
@sentry/browser (incl. sendFeedback) 26.85 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.45 KB (0%)
@sentry/react 24.97 KB (0%)
@sentry/react (incl. Tracing) 36.36 KB (0%)
@sentry/vue 26.33 KB (0%)
@sentry/vue (incl. Tracing) 35.17 KB (0%)
@sentry/svelte 22.36 KB (0%)
CDN Bundle 23.42 KB (0%)
CDN Bundle (incl. Tracing) 35.05 KB (0%)
CDN Bundle (incl. Tracing, Replay) 69.18 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.38 KB (0%)
CDN Bundle - uncompressed 68.8 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 103.66 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 214.13 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 226.79 KB (0%)
@sentry/nextjs (client) 36.24 KB (0%)
@sentry/sveltekit (client) 33.95 KB (0%)
@sentry/node 113.27 KB (+0.03% 🔺)
@sentry/node - without tracing 90.65 KB (+0.05% 🔺)
@sentry/aws-serverless 99.74 KB (+0.04% 🔺)

@mydea mydea changed the title Revert "Revert "feat(node): Allow to configure maxSpanWaitDuration" (#12511)" feat(node): Allow to configure maxSpanWaitDuration Jun 24, 2024
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed this to drop the "revert" part from the PR title, let's :shipit: and adjust the default in a follow up PR!

@lforst
Copy link
Member Author

lforst commented Jun 24, 2024

@mydea I wasn't aware we were gonna change the default. What do we wanna change it to?

@mydea
Copy link
Member

mydea commented Jun 24, 2024

@mydea I wasn't aware we were gonna change the default. What do we wanna change it to?

let's talk about this in a follow up, IMHO I'd make it higher as now, but what... not quite sure. maybe 1h? 🤔

@lforst
Copy link
Member Author

lforst commented Jun 24, 2024

I think we cannot increase it to such a high number with good conscience. The memory pressure buildup could be insane. We should probably limit the number of spans we store in the exporter?

@lforst lforst merged commit 8b8febb into develop Jun 24, 2024
98 checks passed
@lforst lforst deleted the lforst-add-back-wait-duration branch June 24, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Node] Refactor SpanExporter to use getSpanDescendants()
3 participants