-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node): Allow to configure maxSpanWaitDuration
#12610
Conversation
size-limit report 📦
|
maxSpanWaitDuration
" (#12511)"maxSpanWaitDuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed this to drop the "revert" part from the PR title, let's and adjust the default in a follow up PR!
@mydea I wasn't aware we were gonna change the default. What do we wanna change it to? |
let's talk about this in a follow up, IMHO I'd make it higher as now, but what... not quite sure. maybe 1h? 🤔 |
I think we cannot increase it to such a high number with good conscience. The memory pressure buildup could be insane. We should probably limit the number of spans we store in the exporter? |
Adds back #12492.
We were experimenting with #12510 but found it infeasible to do: #12577 (comment)
Closes #12510