Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Tracing Implementation #1918

Merged
merged 11 commits into from Mar 6, 2019
Merged

Open Tracing Implementation #1918

merged 11 commits into from Mar 6, 2019

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Feb 21, 2019

No description provided.

@HazAT HazAT self-assigned this Feb 21, 2019
@HazAT HazAT added this to the 5.0.0 milestone Feb 21, 2019
@HazAT HazAT force-pushed the feat/session-tracking branch 2 times, most recently from 0846fff to c9d7941 Compare February 26, 2019 12:50
@HazAT HazAT marked this pull request as ready for review March 6, 2019 16:36
@HazAT HazAT requested a review from kamilogorek as a code owner March 6, 2019 16:36
@getsentry-bot
Copy link
Contributor

Messages
📖 ✅ TSLint passed
📖 @sentry/browser gzip'ed minified size: $ cat build/bundle.es6.min.js | gzip -9 | wc -c | awk '{$1=$1/1024; print "ES6: ",$1,"kB";}'

Generated by 🚫 dangerJS against 287d633

@HazAT HazAT merged commit 741e3bd into major/5 Mar 6, 2019
@HazAT HazAT deleted the feat/session-tracking branch March 6, 2019 16:53
HazAT added a commit that referenced this pull request Mar 19, 2019
@HazAT
@sentry/opentracing (#1918)
367b99e 
* feat: Add opentracing package

* feat: Add traceId + references

* ref: Rename flush

* fix: Also add operation

* feat: uuid4 split for spanId

* feat: Add link:yarn script

* feat: Update package.json

* feat: Add event type

* ref: Fix span json format

* feat: Documenation

* fix: Tests
HazAT added a commit that referenced this pull request Mar 20, 2019
@HazAT
@sentry/opentracing (#1918)
a4734da 
* feat: Add opentracing package

* feat: Add traceId + references

* ref: Rename flush

* fix: Also add operation

* feat: uuid4 split for spanId

* feat: Add link:yarn script

* feat: Update package.json

* feat: Add event type

* ref: Fix span json format

* feat: Documenation

* fix: Tests
@niieani
Copy link

niieani commented Mar 27, 2019

Hi @HazAT. I realize this is undocumented, but I tried sending some spans and only got some unnamed events. Is this not implemented in the event viewer yet? :)

@HazAT
Copy link
Member Author

HazAT commented Mar 28, 2019

@niieani hehe, you found our secret 🤐
jk, so we are currently implementing this and running internal experiments that's why it's not documented yet. As soon as this works properly we will let people know 😄

@niieani
Copy link

niieani commented Mar 28, 2019

Thought so! 🤓

I'm happy to help beta-testing this, just reach out to me at bbrzoska@zendesk.com.

@HazAT
Copy link
Member Author

HazAT commented Mar 28, 2019

Awesome, will do!

@HazAT
Copy link
Member Author

HazAT commented May 14, 2019

@niieani Here is a forum post, we discontinued the opentracing package.
https://forum.sentry.io/t/sentry-tracing/6681

@niieani
Copy link

niieani commented May 14, 2019

Thanks @HazAT!

@Bessonov Bessonov mentioned this pull request Sep 26, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees

@HazAT HazAT

Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HazAT @getsentry-bot @niieani