feat: New setter for scope #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
reviewed
Feb 28, 2019
| * @param tags Tags context object to merge into current context. | ||
| */ | ||
| setTag(key: string, value: string): Scope; | ||
| setTags(tags?: { [key: string]: string }): this; |
There was a problem hiding this comment.
It's partially true. If you pass setTags({}) it will send old tags, as nothing will get merged. There should also be mention about unsetting.
kamilogorek
suggested changes
Feb 28, 2019
packages/types/src/scope.ts
Outdated
|
|
||
| /** | ||
| * Updates user context information for future events. | ||
| * @param user User context object to be set in the current context. | ||
| * @param user User context object to be set in the current context. If null or undefined user will be unset. |
There was a problem hiding this comment.
If you pass '' or 0 it will unset as well, so we should either explicitly check for no arguments at all or say If passed any falsy value, user will be unset.
kamilogorek
approved these changes
Feb 28, 2019
kamilogorek
pushed a commit
that referenced
this pull request
Mar 1, 2019
* feat: New setter for scope * fix: Comments
kamilogorek
pushed a commit
that referenced
this pull request
Mar 1, 2019
* feat: New setter for scope * fix: Comments
kamilogorek
pushed a commit
that referenced
this pull request
Mar 1, 2019
* feat: New setter for scope * fix: Comments
HazAT
added a commit
that referenced
this pull request
Mar 19, 2019
* feat: New setter for scope * fix: Comments
HazAT
added a commit
that referenced
this pull request
Mar 19, 2019
* feat: New setter for scope * fix: Comments
HazAT
added a commit
that referenced
this pull request
Mar 20, 2019
* feat: New setter for scope * fix: Comments
HazAT
added a commit
that referenced
this pull request
Mar 20, 2019
* feat: New setter for scope * fix: Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.