Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: call RAF with correct context #2570

Merged
merged 1 commit into from
May 6, 2020
Merged

fix: call RAF with correct context #2570

merged 1 commit into from
May 6, 2020

Conversation

kamilogorek
Copy link
Contributor

Fixes #2352

rhcarvalho
rhcarvalho approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@getsentry-bot
Copy link
Contributor

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 16.957 kB) (ES6: 15.9932 kB)
📖 ✅ TSLint passed

Generated by 🚫 dangerJS against d045ce7

@kamilogorek kamilogorek merged commit f119435 into master May 6, 2020
@kamilogorek kamilogorek deleted the raf-context branch May 6, 2020 11:54
@rhcarvalho rhcarvalho mentioned this pull request May 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhcarvalho rhcarvalho rhcarvalho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: 'requestAnimationFrame' called on an object that does not implement interface Window.
3 participants
@kamilogorek @getsentry-bot @rhcarvalho