Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Don't wrap xhr/fetch for sentry breadcrumbs #2615

Merged
merged 8 commits into from
May 27, 2020

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented May 26, 2020

Fixes #2602
Closes #2603

Tests are still broken will fix if this approach is what we want.

@HazAT HazAT requested a review from kamilogorek as a code owner May 26, 2020 13:01
@HazAT HazAT self-assigned this May 26, 2020
@getsentry-bot
Copy link
Contributor

getsentry-bot commented May 26, 2020

Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 16.8018 kB) (ES6: 15.8359 kB)

📖 ✅ TSLint passed

Generated by 🚫 dangerJS against 85b04bc

@kamilogorek kamilogorek self-requested a review May 27, 2020 08:16
@HazAT HazAT merged commit c79bab6 into master May 27, 2020
@HazAT HazAT deleted the hazat/fix-internal-breadcrumbs branch May 27, 2020 08:17
@dashed
Copy link
Member

dashed commented May 27, 2020

This is definitely better 👍 Thanks for looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

envelopes: code expects serialized events in JSON format, not envelopes
4 participants