Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rewriteframes.ts #2673

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Update rewriteframes.ts #2673

merged 1 commit into from
Jun 16, 2020

Conversation

xiaoxiaojx
Copy link
Contributor

Delete useless condition judgment

@xiaoxiaojx
Copy link
Contributor Author

xiaoxiaojx commented Jun 16, 2020

private readonly _iteratee: StackFrameIteratee = (frame: StackFrame) => {
    // here ~
    if (!frame.filename) {
      return frame;
    }
    // Check if the frame filename begins with `/` or a Windows-style prefix such as `C:\`
    const isWindowsFrame = /^[A-Z]:\\/.test(frame.filename);
    const startsWithSlash = /^\//.test(frame.filename);
    if (frame.filename && (isWindowsFrame || startsWithSlash)) {

@kamilogorek kamilogorek merged commit 236f8d7 into getsentry:master Jun 16, 2020
@kamilogorek
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants