-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Strip query and fragment from Angular tracing URLs #2874
Conversation
size-limit report
|
packages/angular/src/tracing.ts
Outdated
op: 'navigation', | ||
}); | ||
} | ||
|
||
if (activeTransaction) { | ||
this._routingSpan = activeTransaction.startChild({ | ||
description: `${navigationEvent.url}`, | ||
description: `${strippedUrl}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have already the stripped URL in the transaction name and the tag, would it make sense to keep the full URL here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your call, I'm fine with any cc @HazAT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, the change is to improve transaction grouping having the full URL here just provides more insights. So I am pro Full URL in description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one question before we merge.
ref: https://app.asana.com/0/1169125731075107/1191128420238986