Fix _processing flag in BaseClient. #2983
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had experienced some problems with
flush()
in a following scenario:I tried to change
fs.readFile
tofs.readFileSync
inpackages/node/src/parsers.ts
but file I/O is not the only issue.beforeSend
callback could result in asynchronous execution too.So my proposal is to change
_processing
fromboolean
tonumber
counter. Another option would be to introduce anotherPromiseBuffer
and justdrain
it. What do you think?