ref(ember): Fix merging of runtime config with environment config. #3563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runtime config initially was meant to act as an override, but moving forward we want to be able to support it accepting the usual Sentry init config so that passing functions is possible.
size-limit report
|
kamilogorek
approved these changes
May 19, 2021
| const initConfig = Object.assign({}, config.sentry, _runtimeConfig || {}); | ||
| // Permanently merge options into config, preferring runtime config | ||
| Object.assign(config.sentry, _runtimeConfig || {}); | ||
| const initConfig = Object.assign({}, config.sentry); |
There was a problem hiding this comment.
The only thing that initConfig does now, is shallow clone of config.sentry. And because the only thing you modify is an object (which is assigned by reference), it's effectively 2 objects with the same values (+ _metadata in case of initConfig). I wonder if it wouldn't be simpler to just go directly with config.sentry passed to Sentry.init instead. If you think not, just ignore the comment.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Runtime config initially was meant to act as an override, but moving forward we want to be able to support accepting the usual Sentry init config so that passing functions is possible and setup and configuration is easier. This PR will allow runtime options to accept Sentry config (addon config will still be handled by the environment config files) and merge it with priority into any existing environment config.
Refs #3562