Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register angular module on plugin load #413

Closed
wants to merge 1 commit into from
Closed

Register angular module on plugin load #413

wants to merge 1 commit into from

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Nov 7, 2015

With this change we're able to reference ngRaven module even before Raven.install() call.


This change is Reviewable

With this change we're able to reference `ngRaven` module even before `Raven.install()` call.
@benvinegar
Copy link
Contributor

One goal I know @mattrobenolt had with Raven.addPlugin was to allow it so that you could load Raven + plugins before libraries like Angular. Unless I'm missing something, with this change, that won't be possible.

But it seems that this patch would be necessary for #414 – i.e. the pain about gaining access to Raven in the Angular ecosystem before install is called is real.

@mattrobenolt – thoughts? Maybe we have to rethink install/addPlugin?

@benvinegar
Copy link
Contributor

@Sija – if you can rebase this / resolve conflicts, I'm fine with merging.

@jonlil
Copy link

jonlil commented Jan 10, 2017

What can I do to help? Need this asap!

@jonlil jonlil mentioned this pull request Jan 10, 2017
@vivoplus
Copy link

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@kamilogorek
Copy link
Contributor

Please refer to #821 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants