ref: Remove the backend #4307
Closed
ref: Remove the backend #4307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The next step here after this gets merged in is to cleanup up the client so the inheritance chain makes more sense |
size-limit report
|
AbhiPrasad
force-pushed
the
abhi-remove-backend
branch
2 times, most recently
from
88a3b19
to
6de9bb7
Compare
This patch removes the backend from the core. It turns `eventFromException` and `eventFromMessage` into abstract methods on the client class (so we can remove the `SentryError` calls) and moves the transport setup from the backend into the client.
AbhiPrasad
force-pushed
the
abhi-remove-backend
branch
from
cd7b0cc
to
21c759c
Compare
|
Closing as we won’t proceed with this until the major. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goodnight sweet prince
https://www.youtube.com/watch?v=3JWTaaS7LdU