fix(tracing): Target tracing bundles for side effects #4955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prepack script runs in bundles mode for this module, which puts the build targets in the root of the package rather than the npm folder. This reverts commit eb09c28.
kpdecker
changed the title
Co-authored-by: Onur Temizkan <onur@narval.co.uk>
|
@onurtemizkan could you approve the PR (of course only if you think it's in a good state)? GH won't let me merge without it |
onurtemizkan
approved these changes
Apr 25, 2022
Lms24
added a commit
that referenced
this pull request
Apr 26, 2022
adjust the fix from #4955 which was merged into 6.19.7 for v7. Change the sideEffects paths in package.json of @sentry/tracing by renaming the `dist` dir to `cjs`.
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
adjust the fix from #4955 which was merged into 6.19.7 for v7. Change the sideEffects paths in package.json of @sentry/tracing by renaming the `dist` dir to `cjs`.
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
adjust the fix from #4955 which was merged into 6.19.7 for v7. Change the sideEffects paths in package.json of @sentry/tracing by renaming the `dist` dir to `cjs`.
3 tasks
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
adjust the fix from #4955 which was merged into 6.19.7 for v7. Change the sideEffects paths in package.json of @sentry/tracing by renaming the `dist` dir to `cjs`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prepack script runs in bundles mode for this module, which puts the build targets in the root of the package rather than the npm folder. https://github.com/getsentry/sentry-javascript/blob/master/scripts/prepack.ts#L20-L21
This was tested manually against webpack 5.56.0.
This reverts commit eb09c28.
Partial #4731