Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add eslint rule to guard against optional chaining in browser SDKs #5305

Closed
wants to merge 2 commits into from
Closed

chore: Add eslint rule to guard against optional chaining in browser SDKs #5305

wants to merge 2 commits into from

Conversation

AbhiPrasad
Copy link
Member

Builds on top of #5304

@AbhiPrasad
fix(core): Remove optional chaining usage
b8c7ab6 
Remove optional chaining usage. This should mean we don't import the
optional chaining polyfill into the browser bundle any more.
@AbhiPrasad
chore: Add eslint rule to guard against optional chaining in browser …
362fae2 
…SDKs
@AbhiPrasad AbhiPrasad mentioned this pull request Jun 23, 2022
Merged
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.4 KB (added)
@sentry/browser - ES5 CDN Bundle (minified) 59.94 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.05 KB (added)
@sentry/browser - ES6 CDN Bundle (minified) 53.28 KB (added)
@sentry/browser - Webpack (gzipped + minified) 19.82 KB (added)
@sentry/browser - Webpack (minified) 64.64 KB (added)
@sentry/react - Webpack (gzipped + minified) 19.84 KB (added)
@sentry/nextjs Client - Webpack (gzipped + minified) 44.08 KB (added)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.77 KB (added)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.1 KB (added)

Lms24
Lms24 requested changes Jun 24, 2022
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the new rules are also applied to test files which I think shouldn't happen. Is there a way we can configure them for sources only (or vice versa, ignore them in tests)?

Base automatically changed from abhi-opt-chain-core to master June 24, 2022 18:10
@AbhiPrasad
Copy link
Member Author

Yeah - we need to not apply them to tests. For now I'm going to close as I don't have the time for this, but I'll open a GH issue.

@AbhiPrasad AbhiPrasad closed this Jun 24, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-opt-chain-eslint branch June 24, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AbhiPrasad @Lms24