Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix): Sourcemaps upload script is missing in the tarball #5356

Merged
merged 3 commits into from
Jul 4, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jul 4, 2022

To upload source maps to Sentry, the Remix SDK includes a script that wraps around Sentry CLI to make uploading sourcemaps easier for our users. However, due to the way how we package our NPM tarballs, this script didn't make it into the Remix SDK tarball.

This PR adds the script to the tarball, which required the following changes:

  • Added a package-specific prepack.ts script which is invoked by the main prepack.ts script. This is similar to how we do it with the Gatsby SDK where - just as with Remix - we need to copy over additional files to the build directory that are not part of our other packages. The newly added files are:
    • scripts/sentry-upload-sourcemaps.js
    • scripts/createRelease.js
  • Added a package-specific .npmignore which extends the root level .npmignore file to not ignore the scripts directory in the build directory.

Fixes #5355

Add prepack script for Remix package and custom .npmignore
@Lms24 Lms24 requested review from onurtemizkan and lforst July 4, 2022 11:17
@Lms24 Lms24 marked this pull request as ready for review July 4, 2022 11:19
@Lms24 Lms24 self-assigned this Jul 4, 2022
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@Lms24 Lms24 merged commit 7a0e72e into master Jul 4, 2022
@Lms24 Lms24 deleted the lms-fix-remix-sourcemaps-script branch July 4, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sourcemaps upload script is missing in the Remix SDK tarball
4 participants