chore: Replace indexOf in favour of includes in isMatchingPattern #5389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Jul 7, 2022
| @@ -97,7 +97,7 @@ export function isMatchingPattern(value: string, pattern: RegExp | string): bool | |||
| return pattern.test(value); | |||
| } | |||
| if (typeof pattern === 'string') { | |||
| return value.indexOf(pattern) !== -1; | |||
| return value.includes(pattern); | |||
There was a problem hiding this comment.
doesn't work in IE11 - and we don't want folks to require the polyfill even when they downcompile
There was a problem hiding this comment.
Interesting. I saw some usage of String.includes() elsewhere in the SDK. I thought it was fair game.
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My small contribution to making the JS SDK bundle smaller.