-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(nextjs): pin @types/react version to fix integration tests #5484
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve to unblock. We'll need to rebase all the PRs once this gets merged in. Let's chat about that strategy in daily.
@@ -16,7 +16,8 @@ | |||
"devDependencies": { | |||
"@types/node": "^15.3.1", | |||
"@types/puppeteer": "^5.4.3", | |||
"@types/react": "^17.0.6", | |||
// Hard-pinning @types/react because 17.0.48 causes build failures | |||
"@types/react": "17.0.47", | |||
"@types/react-dom": "^17.0.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need hard pin @types/react-dom
as well, they need to be kept in sync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinned it to 17.0.17
which seems to be the last version (was released way before @types/react@17.0.48
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, how are you having comments in package.json
??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not, realized this as soon as I pushed it (fixed in 88c171c)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn. I got all excited there for a minute...
Hard-pins
@types/react
to version17.0.47
(and@types/react-dom
to version17.0.17
) because the latest patch (@types/react@17.0.48
) caused our NextJs Integration tests to fail.Caused by: DefinitelyTyped/DefinitelyTyped#61457